Fix condition to keep the compatibility with old version in AWS #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm using the next config in k8s to save in AWS
with the last commit i'm getting the follow error
then i tried with the value, how to indicated the example https://github.com/opencost/opencost-parquet-exporter/blob/v0.2.0/examples/k8s_cron_job.yaml#L39, but don't work
The error is cause by the default value is 'aws' in the main file https://github.com/opencost/opencost-parquet-exporter/blob/main/src/opencost_parquet_exporter.py#L129-L130 but the condition is with 's3' https://github.com/opencost/opencost-parquet-exporter/blob/v0.2.0/src/storage_factory.py#L28
i'm reading about is to keep the compatibility with de old version, therefore i propuse use IN with both values