Skip to content

Commit

Permalink
chore: review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Nil20 committed Sep 18, 2024
1 parent f5b9089 commit e0e088e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

### Breaking changes

- Remove informant notification from the UI and change notification setting in the country config's `application-config.ts` file.
- Remove informant notification configuration from the UI and read notification configuration settings from `record-notification` endpoint in countryconfig
- **Gateways searchEvents API updated** `operationHistories` only returns `operationType` & `operatedOn` due to the other fields being unused in OpenCRVS
- **Config changes to review/preview and signatures** Core used to provide review/preview section by default which are now removed and need to be provided from countryconfig. The signature field definitions (e.g. informant signature, bride signature etc.) were hard coded in core which also have now been removed. The signatures can now be added through the review/preview sections defined in countryconfig just like any other field. You can use the following section definition as the default which is without any additional fields. We highly recommend checking out our reference country repository which has the signature fields in it's review/preview sections

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import fetch from 'node-fetch'
import { logger } from '@opencrvs/commons'

type EventNotificationFlags = {
'sent-notification': boolean
'sent-notification-for-review': boolean
'sent-for-approval': boolean
registered: boolean
'sent-for-updates': boolean
'sent-notification'?: boolean
'sent-notification-for-review'?: boolean
'sent-for-approval'?: boolean
registered?: boolean
'sent-for-updates'?: boolean
}

type NotificationFlags = {
Expand Down

0 comments on commit e0e088e

Please sign in to comment.