Father usual place of residence same as mother. Review just says Yes.

[jpye-finch]

Describe the bug
If the father usual place of residence is the same as the mother the review page show Yes.

It should show the same data as the Mother. Ie. the full address

This applies to 2nd address also if configured.

To Reproduce
Steps to reproduce the behaviour:

1. Create a new form
2. Add mother usual place of residence
3. Say Yes to Father usual place of residence same as mother
4. Nav to review
5. Not error. 'Yes'

Expected behaviour
Should show the same complete address used for the mother.

Tech tasks

• Change the value label for "Yes" to "Same as mother's usual place of residence" and "No" to "Different from mother’s usual place of residence"

[Nil20]

sameUsualPlaceResidence.mp4

[SyedaAfrida]

@anny320 this ticket is fixed and can be closed

[anny320]

Completed

[euanmillar]

@Zangetsu101 we need to discuss and re-open this. The approach @Nil20 made cant work if the address configuration is in Farajaland as per the new config requirements. I need to revert the pull request. I will move to tech design

[euanmillar]

@jpye-finch it is going to be way easier for us to say "Same as mothers" instead of repeating the full address of the mother. Is that OK?

[jpye-finch]

@euanmillar this came up in or review of the Print review page with @rikukissa

For Father details we are seeing:

Usuals place of residence : Yes

We should show the address (populate the mother's address). Or just remove the question 'Same as mother's address' and not allow this shortcut. imo

[rikukissa]

Still happens in QA

[Zangetsu101]

@jpye-finch @euanmillar Which one are we going with?

• Change copy to say "Same as mother's"
• Show the full address (populate using mother's address)
• Remove the question 'Same as mother's address'

[euanmillar]

@Zangetsu101 @rikukissa was going to discuss with @eduffus yesterday if this ticket is essential for 1.5.0 or could be delayed.

[jpye-finch]

If we are not going to fix the issue this release. We should remove the question 'Same as mother's address' in Farajaland configuration

[rikukissa]

@Zangetsu101 @euanmillar steer was if it's not a Tech task, then we shouldn't push tickets out of the release. Is it currently possible to configure the preview label to say "Same as mother's" instead of Yes for this input only using the form configuration?

[jpye-finch]

@rikukissa for me thats not a solution also. As we want the full address so it can be put on the certificate if required.

[jpye-finch]

I have not used this form element in any POC configurations we've done.

[Zangetsu101]

Even with this field present, the full address would be available in the certificate

[eduffus]

If in this case the father's address is still available for use on the certificate, then let's go for a simple change of copy to say "Same as mother's", which is what was asked on the form. Pushing this to a later release means that the demo environment and any country implementation of this would still be wrong.

[tiri39]

This ticket is fixed.

father-usual-place-of-residence-same-as-mother-review-just-say-yes-fixed.mp4

In record correction flow-

father-usual-place-of-residence-same-fixed-2.mp4