Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Print and issue to groom|bride" is added to a different variable… #7112

Merged
merged 7 commits into from
Jun 10, 2024

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Jun 7, 2024

  1. In update modal, multiple item names are showing wrong for marriage declaration #7046
  2. Resend email link button not working during password reset flow #6987
  3. When declaration are being marked as duplicate & archived from the rejection modal, then sent incomplete/ declaration started action is added before archived action in history #7024
  4. Unable to download/ retrieve incomplete marriage declaration without date of marriage #7017
  5. Pagination issue in team when location is changed #6481

@tareq89 tareq89 self-assigned this Jun 7, 2024
tareq89 and others added 6 commits June 7, 2024 19:25
…#7066)

* Fix "Print and issue to groom|bride" is added to a different variable

* groom and bride default name fix

---------

Co-authored-by: Tameem Bin Haider <[email protected]>
* Fix URL path by removing leading slash

This change ensures that the constructed URL uses a relative path instead of an absolute path, appending 'resendAuthenticationCode' correctly to the base URL 'https://gateway.farajaland-qa.opencrvs.org/auth/'.

* chore(changelog)

---------

Co-authored-by: naftis <[email protected]>
…7081)

* Removed duplicateTrackingId check in createDuplicateTask method

* changelog updated
…7038)

* Fix issue #7017: Check for valid date to handle incomplete marriage declarations

Updated logic to use isValidPlainDate function to check date values, ensuring that null or invalid date values do not cause issues. This change allows the retrieval of incomplete marriage declarations even when the date of marriage is missing.

* changelog updated
* Fix: Reset pagination to page 1 when location changes

Ensure the currentPageNumber is reset to 1 whenever the location parameter changes to avoid issues where no data is found and the table and pagination components disappear.

* changelog updated
@tareq89 tareq89 force-pushed the cherrypick-tareq-for-v1.5.0 branch from 545229b to 4edbd56 Compare June 7, 2024 13:28
@Zangetsu101 Zangetsu101 merged commit ebe7541 into release-v1.5.0 Jun 10, 2024
21 checks passed
@Zangetsu101 Zangetsu101 deleted the cherrypick-tareq-for-v1.5.0 branch June 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants