Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move signatures to review/preview section #7114

Merged
merged 35 commits into from
Jul 9, 2024
Merged

refactor: move signatures to review/preview section #7114

merged 35 commits into from
Jul 9, 2024

Conversation

Zangetsu101
Copy link
Collaborator

@Zangetsu101 Zangetsu101 commented Jun 10, 2024 •
edited
Loading

@Zangetsu101
Revert "chore(deps): update dependency lint-staged to v15 (#6942)"
3fc91fc 
This reverts commit 95bf1ee.
@Zangetsu101
feat: allow countryconfig to define preview section
db02f13
@Zangetsu101
feat: render preview section in review page
af02402
@Zangetsu101
feat: create SIGNATURE form field type
3666c5d
@Zangetsu101
refactor: remove unused color prop
a691fbd
@Zangetsu101
feat: add SIGNATURE field to FormFieldGenerator
fac0ac7
@Zangetsu101
refactor: pass props to underlying input element
990175a
@Zangetsu101
fix: change imageUploader's type to be of a button
3be2e5a
@Zangetsu101
feat: forward props to SignatureUploader
59e7d0a
@Zangetsu101
feat: show required error message
d00e840
@Zangetsu101
fix: hide preview section from "review values"
808c196
@Zangetsu101
feat: add maxSizeMb & allowedFileFormats config
551c0ec
@Zangetsu101
refactor: remove informantsSignatureURI
4c979df
@Zangetsu101
fix: add marriage event to ReviewForm component
b41ef3c
@Zangetsu101
feat: provide initial values for preview section
0d523e2
@Zangetsu101
feat: include review section from definition
790aa3e
@Zangetsu101
feat: manage review/preview section on form review
3a52687
@Zangetsu101
refactor: pass form def as prop to ReviewSection
f2942ec
@Zangetsu101
refactor: remove signature uri references
60ef92e
@Zangetsu101
feat: include preview/review sections
775957b
@Zangetsu101
chore: remove remaining uri references
92cf121
@Zangetsu101
feat: validate review/preview sections in form
2392756
@Zangetsu101
chore: pass form definition to ReviewSection
b9342f3
@Zangetsu101
test: update query selector for file upload
51bba6a
@Zangetsu101
chore: use sections from provided form
c027374
@Zangetsu101
test: update mock form values
ca3736f
@Zangetsu101
Merge branch 'develop' into ocrvs-6821
3e1f23b
@naftis naftis self-requested a review June 11, 2024 11:11
naftis
naftis reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good looking stuff, think it makes the mental model of the forms simpler.

naftis
naftis reviewed Jun 25, 2024
View reviewed changes
packages/client/src/components/form/SignatureField/SignatureUploader.tsx
@@ -0,0 +1,260 @@
/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignatureUploader could be in component library too as it's fairly self contained

@rikukissa rikukissa added this to the v1.6.0 milestone Jul 1, 2024
@Zangetsu101 Zangetsu101 merged commit 0a59d8b into develop Jul 9, 2024
22 checks passed
@Zangetsu101 Zangetsu101 deleted the ocrvs-6821 branch July 9, 2024 05:43
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
Placeholder commit for PR #7114
fb0f92a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
💅 Waiting For Review
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Zangetsu101 @naftis @rikukissa