Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove deprecated inputFieldWidth #7364

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore!: remove deprecated inputFieldWidth #7364

merged 1 commit into from
Jul 10, 2024

Conversation

Zangetsu101
Copy link
Collaborator

We removed the usage of the deprecated inputFieldWidth field from countryconfig here: opencrvs/opencrvs-countryconfig#201

This PR deprecates them core entirely

naftis
naftis approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@naftis naftis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense to control the rendering ourselves, helps accessibility and to have a coherent style system.

Is this a breaking change to the country config, should we amend changelog? (and add a chore ! : to underline breaking)

@Zangetsu101
Copy link
Collaborator Author

Makes a lot of sense to control the rendering ourselves, helps accessibility and to have a coherent style system.

Is this a breaking change to the country config, should we amend changelog? (and add a chore ! : to underline breaking)

True let's do that

@Zangetsu101 Zangetsu101 changed the title chore: remove deprecated inputFieldWidth chore!: remove deprecated inputFieldWidth Jul 9, 2024
@Zangetsu101
Copy link
Collaborator Author

@naftis opencrvs/opencrvs-countryconfig#207

@Zangetsu101 Zangetsu101 merged commit 722bfeb into develop Jul 10, 2024
22 checks passed
@Zangetsu101 Zangetsu101 deleted the remove-input-field-width branch July 10, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

@jpye-finch jpye-finch Awaiting requested review from jpye-finch jpye-finch is a code owner

Assignees
No one assigned
Labels
✅ Ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zangetsu101 @naftis