change serving country certificates #7521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
…ve ceritificate components from ui
This reverts commit d07e047.
|
Indeed, seems like a better approach for now 👍 Could you please confirm the certificates also still work offline? |
|
@Zangetsu101 could you also review this please? |
|
We can update the changelog in this PR |
Zangetsu101
requested changes
Aug 27, 2024
Nil20
force-pushed
the
certificate-reconfiguration
branch
from
cc68415
to
84804f9
Compare
Nil20
force-pushed
the
certificate-reconfiguration
branch
from
2ca17e5
to
fa617f5
Compare
Zangetsu101
approved these changes
Aug 28, 2024
Yep. It does. |
Zangetsu101
approved these changes
Aug 28, 2024
Nil20
added a commit
that referenced
this pull request
Aug 29, 2024
* chore: add a proxy route to serve country certificates * chore!: serve certificates from country-config while loading and remove ceritificate components from ui * fix: amend client unit tests * Revert "chore: add a proxy route to serve country certificates" This reverts commit d07e047. * chore: get event certificates with token * chore: remove seeding certificates * fix: keep integrations in config workqueue * fix: reduce number of redux actions * fix: amend error handler message for certificate endpoint in config * fix: amend offline reducers * fix: update offline data properties to proper offline data * chore: revert navigation unit test for config tab * chore: revert offline template data for field agents * chore: refactor certificate fetching handler
Zangetsu101
added a commit
that referenced
this pull request
Sep 2, 2024
(For 1.6) 🍒 Merge changes from PR #7521 to release-v1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country config PR: opencrvs/opencrvs-countryconfig#250
We can token protect the farajaland
certificateroutes like in the farajaland PR which seems like a much simpler approach than creating presigned url like we discussed here.