Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update the order of system user add/edit form fields and labels and remove NID field #7697

Merged
merged 7 commits into from
Oct 17, 2024
Merged

feat: Update the order of system user add/edit form fields and labels and remove NID field #7697

merged 7 commits into from
Oct 17, 2024

Commits on Oct 17, 2024

  1. Ask surname first in the User details form 

    we often receive requests from countries to have the surname first in this form, we have decided to satisfy that requirement by putting surname first for ALL countries.

#6830
    @Siyasanga
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    71e3d27 View commit details
    Browse the repository at this point in the history

  2. Change name and surname labels for User Details form 

    A request came for the clients to change the labels for "First name(s)" to "User's first name". Also change "Last name" to "User's surname" for clarity and less confussion.

#6830
    @Siyasanga
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    898473a View commit details
    Browse the repository at this point in the history

  3. Remove NID field from the user details form 

    Remove the question that asks the user for a national ID number in this form as it is not required

#6830
    @Siyasanga
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    cc7bfba View commit details
    Browse the repository at this point in the history

  4. Remove lang suffix for FamilyName field 

    We no longer need the suffixes for the FamilyName field since we not really using it anywhere

#6830
    @Siyasanga
    Siyasanga Mtshokotsha authored and Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    434ca21 View commit details
    Browse the repository at this point in the history

  5. Add migration to remove NID field from user 

    A requirement from client to remove the NID field since most of the contries are not really using it.

#6830
    @Siyasanga
    Siyasanga Mtshokotsha authored and Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    75dc301 View commit details
    Browse the repository at this point in the history

  6. Record changes in the CHANGELOG 

    To keep track of changes done on this PR

#6830
    @Siyasanga
    Siyasanga Mtshokotsha authored and Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e07a10c View commit details
    Browse the repository at this point in the history

  7. Remove Eng suffix for the firstName in user form 

    We currently don't support milti language support for both surname and
first names so the ENG/EN suffixes are not needed. Also remove EN bits
that were left for the surname field

#6830
    @Siyasanga
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4ff8506 View commit details
    Browse the repository at this point in the history