Integrate Knip

[jamil314]

No description provided.

[github-actions]

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

• Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
• Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
• If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

[rikukissa]

Do we need this custom reporter? If yes, maybe we could create the file in the pipeline especially given that it would be added to the root of the repository

[rikukissa]

Can you supply these options for the knip command inline so we wouldn't need to add a new file to the root of the project? I'm trying to avoid that as for newcomers these files can feel a bit daunting

[rikukissa]

Suggested change

	- name: Create reporter
	run: echo "const reporter = function (options) {const totalIssues = Object.values(options.issues).reduce((acc, issueRecords) =>acc +Object.values(issueRecords).reduce((acc2, issuesInFile) => acc2 + Object.keys(issuesInFile).length,0),0); console.log(JSON.stringify({ totalIssues }))}; export default reporter" > knip-reporter.js
	- name: Create reporter
	run: |
	cat << 'EOF' > knip-reporter.js
	const reporter = function (options) {
	const totalIssues = Object.values(options.issues).reduce(
	(acc, issueRecords) =>
	acc + Object.values(issueRecords).reduce(
	(acc2, issuesInFile) => acc2 + Object.keys(issuesInFile).length,
	0
	),
	0
	);
	console.log(JSON.stringify({ totalIssues }));
	};
	export default reporter;
	EOF

You might be able to do it like this as well

[rikukissa]

Suggested change

	security-scans:
	needs: setup
	runs-on: ubuntu-22.04
	steps:
	- name: Checkout code
	uses: actions/checkout@v4
	- name: Run Trivy vulnerability scanner in fs mode
	uses: aquasecurity/[email protected]
	with:
	scan-type: 'fs'
	scan-ref: '.'
	trivy-config: trivy.yaml

[rikukissa]

Suggested change

"@types/node": "^22.7.9",

[rikukissa]

Suggested change

"typescript": "^5.6.3"

[rikukissa]

Please run graphql type generator

[rikukissa]

Consider moving these somewhere else as well if the component is not used anymore (this being a file for the component originally)