chore: clean up MOSIP code #7879
Open
+7
−857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
commented
Oct 31, 2024
Comment on lines
-227
to
-234
| In OCRVS-1637 https://github.com/opencrvs/opencrvs-core/pull/964 we attempted to create a longitudinal | ||
| record of life events by an attempt to use an existing person in gateway if an identifier is supplied that we already | ||
| have a record of in our system, rather than creating a new patient every time. | ||
| However this supplied identifier cannot be trusted. This could lead to links between persons being abused or the wrong indivdual | ||
| being marked as deceased. | ||
| Any external identifier must be justifiably verified as authentic by a National ID system such as MOSIP or equivalent |
There was a problem hiding this comment.
This premise can be handled within the confirmRegistration / rejectRegistration API endpoints. The MOSIP-API can check if the the NID supplied for the death is valid via MOSIP, and then either confirm or reject.
|
Your environment is deployed to https://clean-mosip.opencrvs.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any MOSIP code handling that is not related to systems/integrations or the national ID webhooks. Let's clean those up when the MOSIP epic gets refined.