-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean up MOSIP code #7879
base: develop
Are you sure you want to change the base?
Conversation
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
In OCRVS-1637 https://github.com/opencrvs/opencrvs-core/pull/964 we attempted to create a longitudinal | ||
record of life events by an attempt to use an existing person in gateway if an identifier is supplied that we already | ||
have a record of in our system, rather than creating a new patient every time. | ||
However this supplied identifier cannot be trusted. This could lead to links between persons being abused or the wrong indivdual | ||
being marked as deceased. | ||
Any external identifier must be justifiably verified as authentic by a National ID system such as MOSIP or equivalent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This premise can be handled within the confirmRegistration
/ rejectRegistration
API endpoints. The MOSIP-API can check if the the NID supplied for the death is valid via MOSIP, and then either confirm or reject.
Your environment is deployed to https://clean-mosip.opencrvs.dev |
This PR removes any MOSIP code handling that is not related to systems/integrations or the national ID webhooks. Let's clean those up when the MOSIP epic gets refined.