fix(ocrvs-7324): remove duplicate sentences from copy #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makelicious
commented
Jul 3, 2024
| @@ -1345,11 +1345,11 @@ form.section.informant.name,,Informant,Informateur | |||
| form.section.informant.title,,Informant's details,information de l'informateur | |||
| form.section.information.birth.bullet1,,I am going to help you make a declaration of birth.,Je vais vous aider à faire une déclaration de naissance. | |||
| form.section.information.birth.bullet2,,As the legal Informant it is important that all the information provided by you is accurate.,"En tant qu'informateur légal, il est important que toutes les informations que vous fournissez soient exactes." | |||
| form.section.information.birth.bullet3,,Once the declaration is processed you will receive you will receive an email to tell you when to visit the office to collect the certificate - Take your ID with you.,"Une fois la déclaration traitée, vous recevrez un courriel vous indiquant quand vous rendre au bureau pour retirer le certificat - Munissez-vous d'une pièce d'identité." | |||
| form.section.information.birth.bullet3,,Once the declaration is processed you will receive an email to tell you when to visit the office to collect the certificate - Take your ID with you.,"Une fois la déclaration traitée, vous recevrez un courriel vous indiquant quand vous rendre au bureau pour retirer le certificat - Munissez-vous d'une pièce d'identité." | |||
There was a problem hiding this comment.
For these bulletN are defined twice. The french translation seems to change but english stays the same. Let me know if it's not intentional
There was a problem hiding this comment.
by twice you mean the birth & death ones? In farajaland we are using same translations but it could be different for a country
There was a problem hiding this comment.
Ah, I misread the strings 😬 . Thanks for clarifying
Zangetsu101
approved these changes
Jul 3, 2024
makelicious
added a commit
that referenced
this pull request
Jul 4, 2024
🍒 Merge changes from PR #192 to release-v1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate sentences