Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCRVS-7404 Fix: Remove unnecessary dividers in the declaration forms #244

Merged
merged 5 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ INSERT CSV ROWS IN ENGLISH ONLY

## Bug fixes

- TBC
- Remove unnecessary UI dividers that add in various sections of the declaration forms(e.g the Death, Birth and Marriage forms) [#244](https://github.com/opencrvs/opencrvs-countryconfig/pull/244)

## 1.5.0 (https://github.com/opencrvs/opencrvs-countryconfig/compare/v1.4.1...v1.5.0)

Expand Down
11 changes: 7 additions & 4 deletions src/form/addresses/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ export const defaultAddressConfiguration: IAddressConfiguration[] = [
},
{
// MOTHER ADDRESS FIELDS
precedingFieldId: 'birth.mother.mother-view-group.mother-nid-seperator',
precedingFieldId:
'birth.mother.mother-view-group.motherBirthRegistrationNumber',
configurations: [
{
config: AddressSubsections.PRIMARY_ADDRESS_SUBSECTION,
Expand All @@ -117,7 +118,8 @@ export const defaultAddressConfiguration: IAddressConfiguration[] = [
},
{
// FATHER ADDRESS FIELDS
precedingFieldId: 'birth.father.father-view-group.father-nid-seperator',
precedingFieldId:
'birth.father.father-view-group.fatherBirthRegistrationNumber',
configurations: [
{
config: AddressSubsections.PRIMARY_ADDRESS_SUBSECTION,
Expand Down Expand Up @@ -266,7 +268,8 @@ export const defaultAddressConfiguration: IAddressConfiguration[] = [
},*/
{
// SPOUSE ADDRESS FIELDS
precedingFieldId: 'death.spouse.spouse-view-group.spouse-nid-seperator',
precedingFieldId:
'death.spouse.spouse-view-group.spouseBirthRegistrationNumber',
configurations: [
{
config: AddressSubsections.PRIMARY_ADDRESS_SUBSECTION,
Expand Down Expand Up @@ -301,7 +304,7 @@ export const defaultAddressConfiguration: IAddressConfiguration[] = [
{
// PLACE OF MARRIAGE ADDRESS FIELDS
precedingFieldId:
'marriage.marriageEvent.marriage-event-details.place-of-marriage-seperator',
'marriage.marriageEvent.marriage-event-details.placeOfMarriageTitle',
configurations: [{ config: EventLocationAddressCases.PLACE_OF_MARRIAGE }]
},
{
Expand Down
4 changes: 0 additions & 4 deletions src/form/birth/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,6 @@ export const birthForm: ISerializedForm = {
hideIfNidIntegrationEnabled.concat(detailsExist),
true
),
// preceding field of address fields
divider('mother-nid-seperator', detailsExist),
// ADDRESS FIELDS WILL RENDER HERE
divider('mother-address-seperator', detailsExist),
getMaritalStatus(certificateHandlebars.motherMaritalStatus, [
Expand Down Expand Up @@ -442,8 +440,6 @@ export const birthForm: ISerializedForm = {
hideIfNidIntegrationEnabled.concat(detailsExist),
true
),
// preceding field of address fields
divider('father-nid-seperator', detailsExist),
// ADDRESS FIELDS WILL RENDER HERE
divider('father-address-seperator', detailsExist),
getMaritalStatus(certificateHandlebars.fatherMaritalStatus, [
Expand Down
2 changes: 0 additions & 2 deletions src/form/death/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -364,8 +364,6 @@ export const deathForm = {
),
getIDType('death', 'spouse', detailsExist, true),
...getIDNumberFields('spouse', detailsExist, true),
// preceding field of address fields
divider('spouse-nid-seperator', detailsExist),
// ADDRESS FIELDS WILL RENDER HERE
divider('spouse-address-separator')
],
Expand Down
3 changes: 1 addition & 2 deletions src/form/marriage/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,7 @@ export const marriageForm: ISerializedForm = {
fields: [
getMarriageDate, // Required field
getTypeOfMarriage,
placeOfMarriageSubsection,
divider('place-of-marriage-seperator')
placeOfMarriageSubsection
// PLACE OF MARRIAGE FIELDS WILL RENDER HERE
]
}
Expand Down
Loading