Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable conditional filtering in document select options #254

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

Zangetsu101
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not sure how to test this locally as we don't have a optionCondition field in CC or Farajaland. If you have some simple form config field I could try out.

@Zangetsu101
Copy link
Collaborator Author

yeah it's difficult to test as you said, you'll just have to trust me on this as I'll testing it with MDG config 😃

@Zangetsu101 Zangetsu101 merged commit aa90500 into develop Sep 12, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@Zangetsu101 Zangetsu101 deleted the filter-options-in-document-select branch September 12, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants