-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: add route to serve record notification #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Zangetsu101
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When writing the CHANGELOG, think from the perspective of a country implementor on what they need to do to ensure notifications are working. This is a breaking change so care should be taken
Nil20
force-pushed
the
record-notification
branch
from
September 18, 2024 12:23
7f56d85
to
7e11a72
Compare
Zangetsu101
changed the title
chore: add route to serve record notification
chore!: add route to serve record notification
Sep 18, 2024
Zangetsu101
approved these changes
Sep 19, 2024
Zangetsu101
added a commit
that referenced
this pull request
Sep 20, 2024
🍒 Merge changes from PR #274 to release-v1.6.0
Siyasanga
pushed a commit
that referenced
this pull request
Oct 16, 2024
* chore: add route to serve record notification * chore: improve record notification types * docs: update changelog for addtion of notification flag * docs: amend changelog for notification flag * docs: rearrange notification flags CHANGELOG entry --------- Co-authored-by: Tameem Bin Haider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.