Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7224 Pull images parallel during deployment #278

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

AshwinMN24
Copy link
Contributor

@AshwinMN24 AshwinMN24 commented Sep 19, 2024

We had first cleaned the docker images from the development env servers before deploying. by using below commands.
docker stack ls
NAME SERVICES
opencrvs 34
docker stack rm opencrvs
docker system prine -af

then had triggered the github action with the code changes from https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 and then repeated the cleanup process and triggered with the old code changes. https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10937970094

As per the pipeline triggered it had taken less time.

@n1koo
Copy link
Member

n1koo commented Sep 20, 2024

Looks good but how was this tested? Can you also describe the intent in few lines on the description?

Longer term we should also have error control here - eg if pull failed we shouldnt move forward. Right now it will just hammer through, but this change doesn't really make it any worse just maintains that

done

echo "Images are getting downloaded"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this disappear in the log output of the pull(s)? Eg are they outputting earlier and parallel so this gets lost in their log output...?

If so we can drop this

Copy link
Contributor Author

@AshwinMN24 AshwinMN24 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I could see it the logs as i have rephrased the sentence "Images download is in process" to "Images are getting downloaded" for better as per the if you check https://github.com/opencrvs/opencrvs-farajaland/actions/runs/10938830700/job/30369325656 (line-194) and in Line- 2190 i have again put check-mark "Images are successfully downloaded" to confirm the images are downloaded and the wait has happened.

CHANGELOG.md Outdated Show resolved Hide resolved
@rikukissa rikukissa merged commit c0ec52d into develop Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants