-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: confirm registration via graphql api #288
Open
naftis
wants to merge
9
commits into
develop
Choose a base branch
from
ocrvs-6208-reject-registration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+208
−2,607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
changed the title
feat: allow confirming registration via the new graphql api
feat(message-queue): confirming registration via graphql api
Sep 30, 2024
naftis
changed the title
feat(message-queue): confirming registration via graphql api
feat(message-queue): confirm registration via graphql api
Sep 30, 2024
rikukissa
reviewed
Oct 2, 2024
rikukissa
approved these changes
Oct 2, 2024
4 tasks
25 tasks
naftis
changed the title
feat(message-queue): confirm registration via graphql api
feat: confirm registration via graphql api
Oct 28, 2024
…into ocrvs-6208-reject-registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirms the registration via a new GraphQL API
confirmRegistration
. This change was made due to OpenCRVS architecturally going to the direction of handling communications only via gateway's GraphQL endpoint. This allows core to only internally access workflow's/confirm/registration
endpoint and clarifies the divide between internal and external endpoints.The change also enables 3rd party extensions (such as national id mediators) to call
confirmRegistration
with the child's identifiers.Important
Depends on opencrvs/opencrvs-core#7674