Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update system user form fields translations #289

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Commits on Oct 17, 2024

  1. Remove NID field from the user details form

    Remove the question that asks the user for a national ID number in the User details form as it is not required
    
    opencrvs/opencrvs-core#6830
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    1ad7a75 View commit details
    Browse the repository at this point in the history
  2. Add back the NID field translations

    The tranlation also get used views/form.ts file which is a different form config file
    
    opencrvs/opencrvs-core#6830
    Siyasanga Mtshokotsha authored and Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ad7332f View commit details
    Browse the repository at this point in the history
  3. Record changes for this PR in the CHANGELOG

    Siyasanga Mtshokotsha authored and Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    92bede8 View commit details
    Browse the repository at this point in the history
  4. Rename firstNameEN to userFirstName in client.csv

    Since the object was to remove the EN suffix, doing that for this key
    would conflict with the already existing 'form.field.label.firstName' so
    to differentiate, I opted to use 'form.field.label.userFirstName' to
    associate it with the user form
    
    opencrvs/opencrvs-core#6830
    Siyasanga committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2aa4c69 View commit details
    Browse the repository at this point in the history