Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCRVS-7404 Fix: Remove unnecessary dividers Mother's form #1081

Closed
wants to merge 4 commits into from
Closed

OCRVS-7404 Fix: Remove unnecessary dividers Mother's form #1081

wants to merge 4 commits into from

Conversation

Siyasanga
Copy link
Collaborator

We had unexpected dividers in the Birth-> Mother section of the form

OCRVS-7404

@Siyasanga Siyasanga changed the title WIP! Remove unnesessary dividers @Mother's form OCRVS-7404 Fix: Remove unnecessary dividers @Mother's form Aug 6, 2024
@Siyasanga Siyasanga self-assigned this Aug 6, 2024
@Siyasanga Siyasanga changed the title OCRVS-7404 Fix: Remove unnecessary dividers @Mother's form OCRVS-7404 Fix: Remove unnecessary dividers Mother's form Aug 6, 2024
@Siyasanga Siyasanga mentioned this pull request Aug 6, 2024
Closed
@Siyasanga Siyasanga linked an issue Aug 7, 2024 that may be closed by this pull request
Multiple dividers in unexpected places in declaration forms opencrvs/opencrvs-core#7404
Closed
@Siyasanga
Remove extra divider on Birth form's mother section
ebaa05d 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
@Siyasanga
Remove extra divider on Birth form's father section
3aad274 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
@Siyasanga
Remove extra divider on Death form's Spouse section
a3ad9c6 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
@Siyasanga
Rm extra divider on Marriage form's placeOfMarriageTitle
60ca09e 
* Also update the precedingFieldId of the defaultAddressConfiguration

(#7404)[opencrvs/opencrvs-core#7404]
@naftis naftis self-requested a review August 14, 2024 08:25
@naftis
Copy link
Collaborator

naftis commented Aug 14, 2024 •
edited
Loading

The changes look good, but we should create a pull request to opencrvs-countryconfig which is the minimal configuration of a country. We then pull changes from countryconfig to Farajaland after a while. We only create pull requests to Farajaland when it's Farajaland specifics (deployment, end-to-end tests, or complex form configurations that we wanna e2e test).

If you could move this PR there with the same changes, it would be great.

@Siyasanga
Copy link
Collaborator Author

Superseded by opencrvs#244

@Siyasanga Siyasanga closed this Aug 19, 2024
@Siyasanga Siyasanga deleted the ocrvs-7404 branch August 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis Awaiting requested review from naftis

Assignees

@Siyasanga Siyasanga

Labels
None yet
Projects
OpenCRVS Core
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple dividers in unexpected places in declaration forms
2 participants
@Siyasanga @naftis