rename visaulization to artifact preview

opendatahub-io · Oct 9, 2024 · 3194d1a · 3194d1a
1 parent 25e1a44
commit 3194d1a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts
@@ -98,7 +98,7 @@ class ArtifactRightDrawer extends Contextual<HTMLDivElement> {
   }
 
   findVisualizationTab() {
-    return this.find().findByRole('tab', { name: 'Visualization' });
+    return this.find().findByRole('tab', { name: 'Artifact preview' });
   }
 
   findIframeContent() {

diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts
@@ -206,7 +206,7 @@ describe('Artifacts', () => {
         );
     });
   });
-  describe('Pipeline run visualization tab', () => {
+  describe('Pipeline run Artifact preview tab', () => {
     beforeEach(() => {
       cy.interceptOdh(
         'GET /api/service/pipelines/:namespace/:serviceName/apis/v2beta1/artifacts/:artifactId',
@@ -224,7 +224,7 @@ describe('Artifacts', () => {
       initMlmdIntercepts(projectName);
     });
 
-    it('check for visualization', () => {
+    it('check for Artifact preview', () => {
       pipelineRunDetails.visit(
         projectName,
         mockPipeline.pipeline_id,

diff --git a/...nes/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx b/...nes/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx
@@ -84,7 +84,7 @@ describe('PipelineRunDrawerRightContent', () => {
 
     expect(tabs).toHaveLength(2);
     expect(screen.getByRole('tab', { name: 'Artifact details' })).toBeVisible();
-    expect(screen.getByRole('tab', { name: 'Visualization' })).toBeVisible();
+    expect(screen.getByRole('tab', { name: 'Artifact preview' })).toBeVisible();
   });
 
   it('renders task drawer tabs when the task prop is of type "groupTask"', async () => {

diff --git a/...ts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx b/...ts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx
@@ -27,7 +27,7 @@ type ArtifactNodeDrawerContentProps = Omit<
 
 enum ArtifactNodeDrawerTab {
   Details = 'details',
-  Visualization = 'visualization',
+  ArtifactPreview = 'artifactPreview',
 }
 
 export const ArtifactNodeDrawerContent: React.FC<ArtifactNodeDrawerContentProps> = ({
@@ -66,9 +66,9 @@ export const ArtifactNodeDrawerContent: React.FC<ArtifactNodeDrawerContentProps>
             </Tab>
             {isMetricsArtifactType(artifact.getType()) && (
               <Tab
-                eventKey={ArtifactNodeDrawerTab.Visualization}
-                title={<TabTitleText>Visualization</TabTitleText>}
-                aria-label="Visualization"
+                eventKey={ArtifactNodeDrawerTab.ArtifactPreview}
+                title={<TabTitleText>Artifact preview</TabTitleText>}
+                aria-label="Artifact preview"
               >
                 <ArtifactVisualization artifact={artifact} />
               </Tab>

diff --git a/...ntent/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx b/...ntent/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx
@@ -115,7 +115,7 @@ describe('ArtifactNodeDrawerContent', () => {
       ),
     );
 
-    await user.click(screen.getByRole('tab', { name: 'Visualization' }));
+    await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
     expect(screen.getByRole('heading', { name: 'Scalar metrics' })).toBeVisible();
   });
 
@@ -154,7 +154,7 @@ describe('ArtifactNodeDrawerContent', () => {
       ),
     );
 
-    await user.click(screen.getByRole('tab', { name: 'Visualization' }));
+    await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
     expect(screen.getByRole('heading', { name: 'ROC curve' })).toBeVisible();
   });
 
@@ -179,7 +179,7 @@ describe('ArtifactNodeDrawerContent', () => {
       </BrowserRouter>,
     );
 
-    await user.click(screen.getByRole('tab', { name: 'Visualization' }));
+    await user.click(screen.getByRole('tab', { name: 'Artifact preview' }));
     expect(screen.getByRole('heading', { name: 'Confusion matrix metrics' })).toBeVisible();
   });
 
@@ -202,7 +202,7 @@ describe('ArtifactNodeDrawerContent', () => {
       </BrowserRouter>,
     );
 
-    expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull();
+    expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull();
   });
 
   it('should not render "Model" visualization drawer tab', async () => {
@@ -224,7 +224,7 @@ describe('ArtifactNodeDrawerContent', () => {
       </BrowserRouter>,
     );
 
-    expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull();
+    expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull();
   });
 });