-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nim double window #3268
Nim double window #3268
Conversation
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue, thanks!
/ok-to-test |
… link to EmptyModelServing for NIM project. Signed-off-by: Olga Lavtar <[email protected]>
4bb073c
to
28e0fd9
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3268 +/- ##
==========================================
- Coverage 84.86% 84.85% -0.02%
==========================================
Files 1306 1306
Lines 29197 29191 -6
Branches 7881 7884 +3
==========================================
- Hits 24779 24770 -9
- Misses 4418 4421 +3
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
Resolved double window and NIM modal showing for KServe. Added a link to EmptyModelServing for NIM project.
How Has This Been Tested?
Tested locally.
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main