Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty state of versions list and models lists #3277

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Oct 1, 2024

Closes: RHOAIENG-12863

Description

This PR aims to update the empty state of versions list and models list to show the secondary action only when there are archived versions / archived models.

How Has This Been Tested?

Check for empty state of versions list with no archived versions.
Check for empty state of models list with no archived models.

Test Impact

NA, just rendering the empty state actions conditionally.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (d5938bf) to head (f311c83).
Report is 54 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
- Coverage   85.06%   84.87%   -0.19%     
==========================================
  Files        1293     1306      +13     
  Lines       28846    29204     +358     
  Branches     7759     7889     +130     
==========================================
+ Hits        24538    24788     +250     
- Misses       4308     4416     +108     
Files with missing lines Coverage Δ
.../src/pages/modelRegistry/screens/ModelRegistry.tsx 100.00% <ø> (ø)
...try/screens/ModelVersions/ModelVersionListView.tsx 87.69% <100.00%> (+1.02%) ⬆️
...elRegistry/screens/ModelVersions/ModelVersions.tsx 100.00% <ø> (ø)
...reens/RegisteredModels/RegisteredModelListView.tsx 81.08% <100.00%> (+1.66%) ⬆️

... and 112 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5938bf...f311c83. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

"View archived models" and "View archived versions" secondary action links are only visible when there are archived models and archived versions respectively.

@YuliaKrimerman
Copy link
Contributor

/lgtm Verified locally, looks good.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ppadti

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 08c8250 into opendatahub-io:main Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants