Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Storage Classes e2e cypress tests #3289

Merged

Conversation

FedeAlonso
Copy link
Contributor

@FedeAlonso FedeAlonso commented Oct 2, 2024

https://issues.redhat.com/browse/RHOAIENG-11613

Description

e2e Cypress test cases for Storage Class Feature

Settings->Storage class view:

  • A non admin user can not acccess to Settings -> Storage classes view
  • The Default label is shown in the grid
  • An admin user can enable a disabled Storage Class
  • An admin user can disable an enabled Storage Class
  • An admin user can set an enabled Storage Class as the default one
  • An admin user can edit an Storage Class

Cluster Storage view from the Cluster Storage DSP tab:

  • Regular user can create a cluster storage using a new storage class
  • A Cluster Storage with a disabled SC shows the deprecated warning
  • If all SC are disabled except one, the SC dropdown should be disabled

How Has This Been Tested?

As there were some UI changes, the tests ran against the local UI and a 2.14 cluster as the backend

image

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Oct 2, 2024
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (c4e2940) to head (5798358).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3289      +/-   ##
==========================================
+ Coverage   84.74%   84.78%   +0.04%     
==========================================
  Files        1308     1308              
  Lines       29242    29242              
  Branches     7936     7936              
==========================================
+ Hits        24781    24793      +12     
+ Misses       4461     4449      -12     
Files with missing lines Coverage Δ
...pages/projects/components/GenericHorizontalBar.tsx 100.00% <ø> (ø)
...es/projects/screens/detail/storage/StorageList.tsx 100.00% <ø> (ø)
...cts/screens/spawner/storage/StorageClassSelect.tsx 93.18% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e2940...5798358. Read the comment docs.

@FedeAlonso FedeAlonso removed the do-not-merge/work-in-progress This PR is in WIP state label Oct 4, 2024
@FedeAlonso FedeAlonso marked this pull request as ready for review October 4, 2024 13:30
@openshift-ci openshift-ci bot requested a review from dpanshug October 4, 2024 13:30
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Fede!
Can you share job results from Jenkins ?

@FedeAlonso
Copy link
Contributor Author

Thank you Fede! Can you share job results from Jenkins ?

@manosnoam As this PR has UI modifications, I'm not running this in jenkins.
The results:

Cluster Storage:
Screenshot from 2024-10-07 13-20-30

Storage Class:
Screenshot from 2024-10-07 13-24-26
(The one that's failing is because when running the UI locally it uses the token from the oc login instead of performing a login. As the OC login is done with an admin user in order to provision, teardown, and have access to admin views, and the test which fails is testing that a non admin user has no access to the storage classes view which is one of those only admin views)

@FedeAlonso
Copy link
Contributor Author

@manosnoam here you have the result of the failing test when executed against a live cluster :
image

@FedeAlonso
Copy link
Contributor Author

I've deleted some tests as they were already done for the mockend environment.
Results:
image

Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a792657 into opendatahub-io:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants