-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIM Model size propagated to the expanded section #3310
Conversation
…e expanded section Signed-off-by: Olga Lavtar <[email protected]>
Hi @olavtar. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 84.76% 84.73% -0.03%
==========================================
Files 1309 1309
Lines 29292 29292
Branches 7955 7955
==========================================
- Hits 24828 24820 -8
- Misses 4464 4472 +8
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/pages/modelServing/screens/projects/ModelMeshSection/ServingRuntimeDetails.tsx
Show resolved
Hide resolved
/ok-to-test |
Signed-off-by: Olga Lavtar <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-14039
Description
The fix to display the correct Model server sizes on the expanded section.
How Has This Been Tested?
Tested locally
Test Impact
Tested with setting the sizes of the Model to Medium, Large and Custom.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main