Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for disabled kebab is missing in Manage permissions page #3346

Merged

Conversation

YuliaKrimerman
Copy link
Contributor

@YuliaKrimerman YuliaKrimerman commented Oct 17, 2024

RHOAIENG-13050

Description

Added a "The default group always has access to model registry" Tooltip for disabled kebab in Manage permissions page when you hover over it
Screenshot 2024-10-16 at 11 14 12 AM

How Has This Been Tested?

On the UI go to Model registry settings table in the Admin section. Click on Manage Permissions Verify whether the first group in "Groups" section in the Users tab has a disabled kebab menu and a tooltip like the screenshot is showing up when we hover over the disabled kebab.

Test Impact

Fixed the tests to pass with the Button now

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (8e85c4f) to head (1149c8b).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3346      +/-   ##
==========================================
+ Coverage   84.81%   84.83%   +0.01%     
==========================================
  Files        1321     1326       +5     
  Lines       29447    29678     +231     
  Branches     8038     8119      +81     
==========================================
+ Hits        24976    25176     +200     
- Misses       4471     4502      +31     
Files with missing lines Coverage Δ
...pts/roleBinding/RoleBindingPermissionsTableRow.tsx 90.16% <100.00%> (+0.33%) ⬆️

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e85c4f...1149c8b. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit otherwise lgtm

@@ -173,9 +178,18 @@ const RoleBindingPermissionsTableRow: React.FC<RoleBindingPermissionsTableRowPro
/>
</SplitItem>
</Split>
) : isDefaultGroup ? (
<Tooltip content="The default group always has access to model registry">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full stop missing at the end according to design

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Added.

@manaswinidas
Copy link
Contributor

@yih-wang can you have a look at the screenshot, please?

@manaswinidas
Copy link
Contributor

manaswinidas commented Oct 17, 2024

@YuliaKrimerman can you add manual testing instructions in the "How has this been tested?" section. It will really be helpful for anyone outside of our scrum and/or QAing. For example, Instructions like 1. Go to Model registry settings table in the Admin section 2. Go to Manage Permissions 3. Check whether the first group in "Groups" section in the Users tab has a disabled kebab menu and a tooltip like the screenshot.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested whether the tooltip is present.

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2024
@yih-wang
Copy link

LGTM, thanks @YuliaKrimerman !

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shame that we can't just pass a disabledTooltip into ActionsColumn, but that's a PF problem for another time and maybe not worth addressing.

Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0cb198c into opendatahub-io:main Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants