-
Notifications
You must be signed in to change notification settings - Fork 135
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(feature): only relies on desired state for reconcilation
This change ensures that management state is based exclusively on a resource defined in desired state, i.e. the one provided by the controller itself. This can be, but is not limited to, manifest files provided through embedded file system. Although the actual instance on the cluster (the target) might be in a different state, we intentionally do not address this scenario due to the lack of clear requirements on the extent to which users can modify such resource. This change allows to take control over previously undefined resources, so those which are created by `Feature` API without explicit management state defined. As long as original Feature does not have `Managed()` called in the builder chain, nor used manifests have the label explicitly defined the behaviour remain unchanged, that means the resources being part of such a feature are not managed and thus not reconciled after initial apply. To be aligned with how `opendatahub.io/managed` is used by other components, this change makes it a `label`, not an `annotation` as it was previously defined. Follow up to #974
- Loading branch information
1 parent
67309b6
commit 673fb94
Showing
8 changed files
with
85 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
tests/integration/features/fixtures/templates/local-gateway-svc.tmpl.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters