feat: remove modelserving from dashboard manifests #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
May 31, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3038bff
into
opendatahub-io:incubation
8 checks passed
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
May 31, 2024
Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 3038bff)
VaishnaviHire
added a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
May 31, 2024
feat: remove modelserving from dashboard manifests (opendatahub-io#1029)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dashboard removed modelserving path and this breaks odh incubation build.
code has been synced to downstream so the change is for both ODH and downstream
ref: opendatahub-io/odh-dashboard#2706
Description
How Has This Been Tested?
local build quay.io/wenzhou/opendatahub-operator:2.12.1
Merge criteria: