Revert "chore: remove duplicated logic by function call (#1080)" #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic (opendatahub-io#996)" This reverts commit 55320b6.
zdtsw
requested review from
VaishnaviHire and
asanzgom
and removed request for
adelton and
lphiri
CFSNM
approved these changes
Jul 9, 2024
|
@CFSNM: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
asanzgom
approved these changes
Jul 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asanzgom, CFSNM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
bartoszmajsak
pushed a commit
to bartoszmajsak/opendatahub-operator
that referenced
this pull request
Jul 10, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 11, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 19, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6. (cherry picked from commit 011c946)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6. (cherry picked from commit 011c946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f3e6a13.
previous cleanup removed the error from component when ossm and or authorino is not installed
which is causing DSC does not show error but keep reconcile on kserve
this is to revert the change to keep both in DSC and DSCI do the dependent check
Description
https://issues.redhat.com/browse/RHOAIENG-9664
How Has This Been Tested?
Screenshot or short clip
Merge criteria