Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip create usergroups if group CRD does not exsit in cluster #1276

Closed
wants to merge 2 commits into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 4, 2024

Description

  • this will make operator work but dashboard etc which rely on it wont work if components are not disabled
    Signed-off-by: Wen Zhou [email protected]

local build quay.io/wenzhou/opendatahub-operator-catalog:v2.14.1004

postivie case:

  • test on the normal HCP and groups get created
    negative case:
  • when remove config/crd/external/user.openshift.io_groups.yaml and do "make unit-test" also work
  • but will need to test it on HCP with external-auth-provider as well to see how it work ====> TODO

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- this will make operator work but dashboard etc which rely on it wont work if components are not disabled
Signed-off-by: Wen Zhou <[email protected]>
Copy link

openshift-ci bot commented Oct 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member Author

zdtsw commented Oct 4, 2024

fyi @VaishnaviHire

@zdtsw
Copy link
Member Author

zdtsw commented Oct 11, 2024

close it in favor of #1297

@zdtsw zdtsw closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant