Added code coverage guidelines #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## incubation #1302 +/- ##
=============================================
Coverage ? 19.19%
=============================================
Files ? 30
Lines ? 2683
Branches ? 0
=============================================
Hits ? 515
Misses ? 2106
Partials ? 62 ☔ View full report in Codecov by Sentry. |
asanzgom
force-pushed
the
feature/codecov_contribution_guidelines
branch
from
e54d2a2
to
ffb878e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 12fd9e5
into
opendatahub-io:incubation
6 checks passed
|
The patch still named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Contribution Guidelines to include the test coverage in order to increase it with every new feature added to the code and add related unit tests that cover the new lines of code.
How Has This Been Tested?
Screenshot or short clip
Merge criteria