Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the torch version dependency #84

Closed
wants to merge 21 commits into from

Conversation

fabiendupont
Copy link

The PyTorch project has released the patch version 2.3.1 with a number of fixes. This change relaxes the version in the requirements files for build and CUDA, in order to allow picking fixes, while not bumping to the next minor version.

Copy link

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabiendupont
Once this PR has been reviewed and has the lgtm label, please assign xaenalt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 9, 2024

Hi @fabiendupont. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtrifiro
Copy link

dtrifiro commented Jul 9, 2024

torch==2.3.0 is also a build dependency in `pyproject.toml

@fabiendupont
Copy link
Author

torch==2.3.0 is also a build dependency in `pyproject.toml

Thanks. Commit amended.

@dtrifiro
Copy link

@fabiendupont this looks good but would you mind applying the same changes to requirements-cpu.txt? thanks

The PyTorch project has released the patch version 2.3.1 with a number
of fixes. This change relaxes the version in the requirements files for
build and CUDA, in order to allow picking fixes, while not bumping to
the next minor version.

Signed-off-by: Fabien Dupont <[email protected]>
@fabiendupont
Copy link
Author

@dtrifiro, done. Sorry for the delay.

@@ -2,6 +2,6 @@
-r requirements-common.txt

# Dependencies for x86_64 CPUs
torch == 2.3.1+cpu; platform_machine != "ppc64le"
torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le"
Copy link

@dtrifiro dtrifiro Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks broken:

 error in vllm setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Local version label can only be used with `==` or `!=` operators
      torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le"
            ~~~~~~~~^
  error: subprocess-exited-with-error

You can test this with env VLLM_CPU_DISABLE_AVX512=true VLLM_TARGET_DEVICE=cpu PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu pip install -e . -v

I think it's enough to specify two torch lines:

Suggested change
torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le"
torch >= 2.3.1+cpu; platform_machine != "ppc64le"
torch < 2.4.0+cpu; platform_machine != "ppc64le"

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtrifiro
Copy link

dtrifiro commented Aug 6, 2024

Torch is now set at 2.4.0, so this is not needed anymore.

@dtrifiro dtrifiro closed this Aug 6, 2024
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants