Prepare the plugin to an elasticsearch 7.17.24 upgrade #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the 'ESTestCase' class.
This test is used to check if this Polygon is estimated as Valid without a "Tesselate issue". * it should fail with Lucene < 8.11.3 * See these related Pull Requests - apache/lucene-solr#2452 Don't introduce collinear edges when splitting polygon - apache/lucene-solr#2664
and avoid a failure on the './gradlew check' task with this following error:
java.lang.NoSuchMethodError: 'org.gradle.api.services.internal.BuildServiceProvider org.gradle.api.services.internal.BuildServiceRegistryInternal.consume(java.lang.String, java.lang.Class)'
* docker-compose.yml * and docker/Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the plugin with a more recent
7.17.xElasticsearch version.Changes
Change the elasticsearch version to 7.17.24
Update the
build.gradleadding this kind of linein order to avoid the test compilation failure
java.lang.RuntimeException: unable to install test security managerupgrade Gradle to 8.10.2 (the previous 7.5.1 version raised an exception on the
checktask with an error which looked likejava.lang.NoSuchMethodError: 'org.gradle.api.services.internal.BuildServiceProvider org.gradle.api.services.internal.BuildServiceRegistryInternal.consume(java.lang.String, java.lang.Class)')add some content to the README file
How to reproduce
Install Java 17. I suggest you to use sdkman tool which can help you to install any JVM for several languages (Kotlin, Java, Clojure, ...).
If you have an old build, I can also suggest you to remove the Docker image related to the
elasticsearch-plugin-debugcontainer and also remove the local.gradlefolder.If you use sdkman and you installed for instance
17.0.12-tem(OpenJDK by Eclipse Temurin)skd use java 17.0.12-tem./gradlew buildwhich compiles the code and run the testsdocker compose uppathhierarchy-aggregation-7.17.24.0.zipin the folderbuild/distributionshttp :9200/_cat/pluginsto check the plugin