Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix allowed change ref types environment read #1253

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

aoteropas
Copy link

@aoteropas aoteropas commented Dec 4, 2023

change the name of the variable in the if clause for the one that contains the env values. Follow the same approach that other Env Variables

Closes #1252

change the name of the variable in the if clause for the one that contains the env  values.
Follow the same approach that with other Env Variables
michaelsauter
michaelsauter previously approved these changes Dec 4, 2023
@BraisVQ
Copy link
Contributor

BraisVQ commented Dec 4, 2023

This change now make Webhook Proxy load the modified parameters but something is not working properly just yet

2023/12/04 10:03:07 zCNVmE Skipping change ref type BRANCH as ALLOWED_CHANGE_REF_TYPES does not include it
2023/12/04 10:03:59 PFYwTB -----
2023/12/04 10:03:59 PFYwTB Skipping change ref type TAG as ALLOWED_CHANGE_REF_TYPES does not include it

when reading the env variable it is set to lower to unify the values. 
setting to lower the request information to ensure that comparison works
Copy link
Contributor

@jafarre-bi jafarre-bi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these values are turned lowercase, allowedChangeRefTypesDefault should also have a lowercase value. Otherwise, the fix looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error adding ALLOWED_CHANGE_REF_TYPES as env variable
4 participants