-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helmStringValues support #1180
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both values and string values? We are using strings in both cases. Not sure about its usefulness.
Apart from that, this is a new parameter that we need to reflect in the TIR. The changes to the TIR are about to be merged. When that is ready, merge those changes into this branch and add the support for this new parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please wait for the changes to the TIR which are about to be merged and then update the TIR with this new parameter.
It is possible that someone has been using existing automatic type conversion. A hypothetical example:
The above works, because it becomes |
Fixes #1179