Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build with core #337

Merged
merged 35 commits into from
Apr 27, 2024
Merged

Fix CI build with core #337

merged 35 commits into from
Apr 27, 2024

Conversation

andiwand
Copy link
Member

@andiwand andiwand commented Apr 20, 2024

Fixes #336

pdfConverter.setOutline(false).setBackgroundFormat("jpg").setDRM(false);
pdfConverter.setDRM(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomTasche @ViliusSutkus89 do you know what should be done here? It complained about the functions being not existent and I just removed the calls for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember correctly that disables the overview of pages on the left side, so it was quite important for us! can you remember why it was removed? @ViliusSutkus89

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was just replaced with a different method?

What confused me is why does this break now? Are we not pinning the version correctly of this library?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the outline is now visible (black bar on the left in screenshot), which is not what we want. we can't release like that 😞 help @ViliusSutkus89
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is this problem still relevant? I've tried running current main version and outline isn't there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually didn't try and just made it compile. Did you try @TomTasche ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, all good!

@andiwand andiwand requested a review from TomTasche April 21, 2024 13:19
@andiwand andiwand mentioned this pull request Apr 21, 2024
@andiwand andiwand merged commit 8cc5db6 into master Apr 27, 2024
3 checks passed
@andiwand andiwand deleted the fix-ci-conan-core branch April 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid can't update
3 participants