add arm64 support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subham <[email protected]>
|
Hi Team, |
semekh
reviewed
Jul 27, 2022
Comment on lines
+24
to
+41
| - stage: build-arm | ||
| arch: arm64 | ||
| script: ./.ci/build.sh | ||
| - stage: e2e-test-arm | ||
| arch: arm64 | ||
| install: ./.ci/e2e-test/setup.sh | ||
| if: tag IS present OR commit_message =~ /perform-e2e/ | ||
| script: ./.ci/e2e-test/test.sh | ||
| env: | ||
| - CHANGE_MINIKUBE_NONE_USER=true | ||
| - MINIKUBE_WANTUPDATENOTIFICATION=false | ||
| - MINIKUBE_WANTREPORTERRORPROMPT=false | ||
| - MINIKUBE_HOME=$HOME | ||
| - CHANGE_MINIKUBE_NONE_USER=true | ||
| - KUBECONFIG=$HOME/.kube/config | ||
| - stage: publish-arm | ||
| arch: arm64 | ||
| script: ./.ci/publish.sh |
There was a problem hiding this comment.
Looks like a code duplication to me. Do you think we could avoid that somehow?
semekh
requested changes
Jul 27, 2022
I think we need to go with this only because when I try to reduce the duplication it does not run for all the stages. |
|
Hi Team, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following file has been created and modified:
Added support for arm64 in .travis.yml to make docker images and publish them on docker hub.
Note: I have not added the e2e-testing for the arm64 platform because e2e-testing requires minikube to run on travis for arm64 platform. And travisCI does not support minikube on the arm64 platform. There is an open issue for this in kubernetes/minikube.
Signed-off-by: odidev [email protected]