♻️ refactor: some chart improvments and optimizations #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making images customizable adding StorageClass management via helm chart move to `registry.k8s.io` for kubernetes images (all of the images are available there) switch from yaml anchors/pointers to global values and helpers to handle default values so it will make customizations easier for resources/images getting default tag from appVersion in Chart.yaml dataDir path for plugin is customizable now documenting chart using helm-docs tool (with comments in values file) Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
…new changes Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
…igurations Signed-off-by: Muhammed Hussein Karimi <[email protected]>
|
I think I'm almost done with this PR, Can you review this? |
orville-wright
added
documentation
This was
linked to
issues
May 4, 2024
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @semekh
Excuse me for making lots of changes in a single PR, But I tried to document change here and in my commit description
making images customizable
adding StorageClass management via helm chart
move to
registry.k8s.iofor kubernetes images (all of the images are available there)switch from yaml anchors/pointers to global values and helpers to handle default values so it will make customizations easier for resources/images
getting default tag from appVersion in Chart.yaml
dataDir path for plugin is customizable now (closes #3)
documenting chart using helm-docs tool (with comments in values file)
Also I wanted to add VolumeSnapshotClasses but I don't know if there is any parameter required to make snapshotclass working,
if you give me examples I will add it too
As for chart changes I don't know it I have to bump major or minor
If it's OK I want to also add GitHub actions to use GH-Pages for Helm chart publish and removing the need of cloning git repo to install the chart