Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adaptive display of links 'Learn more' and 'Share feedback' #34432

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: adaptive display of links 'Learn more' and 'Share feedback' #34432

merged 1 commit into from
Oct 15, 2024

Conversation

DmytroAlipov
Copy link
Contributor

Description

Do not display the 'Learn more' and 'Share feedback' links for the banner that is enabled by the context_course.discussions_settings flag if the URLs for these links are not set in the settings.

  • DISCUSSIONS_INCONTEXT_LEARNMORE_URL
  • DISCUSSIONS_INCONTEXT_FEEDBACK_URL
screen_50

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 27, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 27, 2024 •
edited
Loading

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov mentioned this pull request Mar 27, 2024
Open
Anas12091101
Anas12091101 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Anas12091101 Anas12091101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dyudyunov pushed a commit to GSVlabs/philu-edx-platform that referenced this pull request Apr 18, 2024
feat: [RGOeX-26488] adaptability display of links
a1756bb 
Hide Learn more and Share feedback links on the studio
discussions info banner if the corresponding settings are empty.
Should be dropped when upstream PR will be merged:
- master openedx#34432,
- quince openedx#34433.
YT:
- https://youtrack.raccoongang.com/issue/RGOeX-26488
dyudyunov pushed a commit to GSVlabs/philu-edx-platform that referenced this pull request Apr 18, 2024
fix: [RGOeX-26471] setting doesn't influence the certificate
f509aee 
"Course Number Display String" option doesn't influence
certificate.

YT:
- https://youtrack.raccoongang.com/issue/RGOeX-26471

Should be dropped when upstream PR will be merged:
- openedx#34432
- openedx#34433
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label May 16, 2024
@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 @Anas12091101 friendly ping

@pdpinch
Copy link
Contributor

pdpinch commented Jul 19, 2024

Where do these settings get set? Do they have annotations per OEP-17?

@mphilbrick211
Copy link

Where do these settings get set? Do they have annotations per OEP-17?

@DmytroAlipov flagging the above comment. Also, it looks like some tests may still need to be run.

@mphilbrick211 mphilbrick211 added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Jul 25, 2024
@DmytroAlipov
Copy link
Contributor Author

DmytroAlipov commented Jul 26, 2024 •
edited
Loading

@pdpinch hi
I added to the logic these variables that were created earlier:

@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 30, 2024
@DmytroAlipov DmytroAlipov force-pushed the add-adaptive-display-of-links branch 5 times, most recently from 613e88d to 8cb858e Compare July 31, 2024 14:28
@pdpinch
Copy link
Contributor

pdpinch commented Sep 16, 2024

@DmytroAlipov this could use a rebase.

I would also be greatly obliged if you would add some annotations to the settings per OEP-17. They shouldn't have been added without them.

@pdpinch
Copy link
Contributor

pdpinch commented Oct 1, 2024

@DmytroAlipov I'd really like to help you merge this, but it needs a rebase.

@DmytroAlipov DmytroAlipov force-pushed the add-adaptive-display-of-links branch from 8cb858e to 7cd5e93 Compare October 7, 2024 06:13
@DmytroAlipov
Copy link
Contributor Author

@pdpinch hi!
Done

@pdpinch
Copy link
Contributor

pdpinch commented Oct 9, 2024

Sorry @DmytroAlipov but I wasn't quick enough and it needs another rebase.

@DmytroAlipov DmytroAlipov force-pushed the add-adaptive-display-of-links branch from 7cd5e93 to eeb2d89 Compare October 9, 2024 13:54
@DmytroAlipov
Copy link
Contributor Author

@pdpinch done 😉

@DmytroAlipov DmytroAlipov force-pushed the add-adaptive-display-of-links branch 4 times, most recently from 8379d1b to 348265b Compare October 11, 2024 15:05
@DmytroAlipov
feat: adaptive display of links
e4c6956 
Do not display the 'Learn more' and 'Share feedback' links for
banner that is enabled by the context_course.discussions_settings
flag if the URLs for these links are not set in the settings.
@DmytroAlipov DmytroAlipov force-pushed the add-adaptive-display-of-links branch from 348265b to e4c6956 Compare October 12, 2024 11:07
@pdpinch pdpinch merged commit c3d68b1 into openedx:master Oct 15, 2024
49 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@DmytroAlipov DmytroAlipov deleted the add-adaptive-display-of-links branch October 16, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anas12091101 Anas12091101 Anas12091101 approved these changes

@pdpinch pdpinch pdpinch approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DmytroAlipov @openedx-webhooks @pdpinch @mphilbrick211 @edx-pipeline-bot @Anas12091101