-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feanil/fix docs build #36004
Closed
Closed
feanil/fix docs build #36004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feanil
commented
Dec 10, 2024
- fix: do not open mfe editors automatically on block paste (fix: do not open mfe editors automatically on block paste #35729)
- chore: upgrade edx-search to 4.1.1 (chore: upgrade edx-search to 4.1.1 #35756)
- fix: adds content.search to docs apps
- build: kickoff the Sumac release
- fix: bump MAX_BLOCKS_PER_CONTENT_LIBRARY default to 100,000 (fix: bump MAX_BLOCKS_PER_CONTENT_LIBRARY default to 100,000 #35768)
- fix: remove the "Legacy Library" button if libraries v1 are disabled (fix: remove the "Legacy Library" button if libraries v1 are disabled [FC-0062] #35736) ([sumac] fix: remove the "Legacy Library" button if libraries v1 are disabled [FC-0062] #35792)
- fix: allow non-Elasticsearch search engines when reindexing courses [FC-0062] (fix: allow non-Elasticsearch search engines when reindexing courses [FC-0062] #35743)
- fix: set upstream link for re-copied block from course originally from library (fix: set upstream link for re-copied block from course originally from library #35784) ([sumac] fix: set upstream link for re-copied block from course originally from library (#35784) #35801)
- fix: image aspect ratio on component preview (fix: image aspect ratio on component preview [FC-0062] [sumac] #35791)
- test: re-enable content libraries runtime tests [FC-0062] (Re-enable content libraries runtime tests [FC-0062] #35783) (test: re-enable content libraries runtime tests [FC-0062] (#35783) #35810)
- fix: component asset api views (fix: component asset api views #35765) ([sumac] fix: component asset api views (#35765) #35800)
- fix: hide library_v2 and itembank in legacy library page (fix: hide library_v2 and itembank in legacy library page #35772) ([sumac] fix: hide library_v2 and itembank in legacy library page #35773)
- Merge pull request feat: [FC-0047] Implement user's enrolments status API (#2530) #34859 from raccoongang/kireiev/AXM-549/feat/upstream_PR_active_inactive_courses_API
- [sumac] fix: keep library collection card component count in sync (fix: Keep sync component count in collection card [FC-0062] #35734) ([sumac] fix: keep library collection card component count in sync (#35734) #35886)
- fix: bypass access checks when populating course blocks cache
- test: add tests
- style: pylint
- test: add tests for known and unknown user
- refactor: revert imports
- refactor: revert imports
- style: pycodestyle fix
- refactor: update docs
- test: add tests when user is not in any group
- chore: Bump openedx-learning to version 0.18.1 (chore: Bump openedx-learning to version 0.18.1 #35931)
- fix: docs build issues (Fix readthedocs build fail #35978)
- fix: content libraries permissions
- feat: Integrate Forum V2 into edx-platform
- fix: flag API positional arguments
- feat: upgrade openedx-forum to v0.1.4
- refactor: Update get block OLX view to support versions (backport) (refactor: Update get block OLX view to support versions [FC-0062] #35932) ([sumac] refactor: Update get block OLX view to support versions [FC-0062] #35973)
- feat: incremental reindex_studio management command (backport) (feat: incremental reindex_studio management command [FC-0062] [Backport] #35981)
- chore: upgrade Django to v4.2.17
- fix: return empty list when no courses are found for request (fix: return empty list when no courses are found for request #35942)
- fix: render library assets named xblock-
- fix: Build docs with python 3.11
(cherry picked from commit c432a8f)
This is to benefit from the latest changes concerning meilisearch index creation: openedx/edx-search#166
This kicks off the Sumac release! We follow the instructions from: https://openedx.atlassian.net/wiki/spaces/COMM/pages/19662426/Process+to+Create+an+Open+edX+Release
build: kickoff the Sumac release
fix: adds content.search to docs apps (Sumac backport)
(cherry picked from commit 952ba95)
…35810) * test: run content_libraries runtime tests * test: fix broken tests * test: fix lms tests Co-authored-by: Kyle D. McCormick <[email protected]> (cherry picked from commit db587bd)
…eam_PR_active_inactive_courses_API feat: [FC-0047] Implement user's enrolments status API (#2530)
[BACKPORT][SUMAC] feat: [FC-0047] Implement user's enrolments status API (#2530)
…5734) (#35886) * fix: keep library collection card component count in sync (#35734) Fixed component counter synchronization in these cases: * When deleting a component inside a collection. * With the library published, when adding a new component in a collection and reverting library changes. * With the library published, when deleting a component inside a collection and reverting library changes. Also adds a published > num_counts field in collections in the search index. * fix: remove learner_downloadable field references from libraries (#35788) Also bumps openedx-learning to v0.17.0, which no longer has this field. * chore: Update common_contraints.txt --------- Co-authored-by: Cristhian Garcia <[email protected]>
[Backport] fix: bypass access checks when populating course blocks cache
This PR changes the permissions for content libraries so that only people who can create courses should be allowed to create new content libraries.
This commit introduces the new Forum V2 application, allowing users to choose between the legacy Forum V1 and the new Forum V2 at the course level. Key Changes: - Added waffle flag `discussions.enable_forum_v2` to enable Forum V2 for selected courses, allowing coexistence with Forum V1. - Default data storage for Forum V2 is set to MongoDB, with an option to switch to MySQL using the waffle flag `forum_v2.enable_mysql_backend`. - Introduced management command `forum_migrate_course_from_mongodb_to_mysql` for per-course data migration from MongoDB to MySQL. Note: This PR does not include all unit tests for the Forum V2 native API due to ongoing migration efforts. Further updates will follow to ensure full test coverage before final release. Co-authored-by: [Muhammad Faraz Maqsood] <[email protected]> Co-authored-by: [Ali Salman] <[email protected]>
To reproduce the error: - switch to mongodb from mysql for a specific course. - create a thread and report the thread. It'll throw an error due to wrong positioning of the arguments. So, this commit - uses keyword arguments in flag APIs - adds mock tests for code coverage
Backported because this fixes an issue where large instances couldn't use this command/feature at all.
This change addresses an issue reported while testing Sumac, where the API V2 is on by default in the authoring MFE: openedx/wg-build-test-release#428. It fails when retrieving an empty list of courses with the queryparams api/contentstore/v2/home/courses?page=1&order=display_name. When this was implemented, the course authoring MFE rendered the empty lists only with page=1 query param (didn't do any filtering/ordering by default), which was later changed to page=1&order=display_name which now ordered by default. This issue occurs because all the filtering and ordering are done under the assumption that course_overviews is always a query set. However, that's only true when there are courses available and CourseOverview.get_all_courses is used. When not, an empty list is returned instead, raising a 500 error in Studio.
The previous pattern for matching was too broad and would break the rendering of assets that were prefixed with "xblock".
We're still running with 3.11 in sumac so we should be building the docs with python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.