Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feanil/fix docs build #36004

Closed
wants to merge 40 commits into from
Closed

feanil/fix docs build #36004

wants to merge 40 commits into from

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Dec 10, 2024

navinkarkera and others added 30 commits October 30, 2024 13:30
This is to benefit from the latest changes concerning meilisearch index
creation: openedx/edx-search#166
fix: adds content.search to docs apps (Sumac backport)
…35736) (#35792)

Removes the "Legacy Library" button from the legacy Studio "new block" button array if Libraries v1 are disabled, either via waffle flag or via the ENABLE_CONTENT_LIBRARIES feature flag.

(cherry picked from commit 9bfdfeb)
…m library (#35784) (#35801)

Sets upstream link to library block for blocks that were copied from a course block which were originally copied/imported from a library.

(cherry picked from commit d82aada)
…35810)

* test: run content_libraries runtime tests

* test: fix broken tests

* test: fix lms tests

Co-authored-by: Kyle D. McCormick <[email protected]>
(cherry picked from commit db587bd)
Uses drf view to authenticate user before allowing them to access library static assets.

(cherry picked from commit ca7da37)
…5773)

Hide options to add library_v2 and itembank blocks in legacy library
page.

(cherry picked from commit 68739ce)
…eam_PR_active_inactive_courses_API

feat: [FC-0047] Implement user's enrolments status API (#2530)
[BACKPORT][SUMAC] feat: [FC-0047] Implement user's enrolments status API (#2530)
…5734) (#35886)

* fix: keep library collection card component count in sync (#35734)

Fixed component counter synchronization in these cases:

* When deleting a component inside a collection.
* With the library published, when adding a new component in a collection and reverting library changes.
* With the library published, when deleting a component inside a collection and reverting library changes.

Also adds a published > num_counts field in collections in the search index.

* fix: remove learner_downloadable field references from libraries (#35788)

Also bumps openedx-learning to v0.17.0, which no longer has this field.

* chore: Update common_contraints.txt

---------

Co-authored-by: Cristhian Garcia <[email protected]>
[Backport] fix: bypass access checks when populating course blocks cache
rpenido and others added 10 commits December 6, 2024 09:18
This PR changes the permissions for content libraries so that only
people who can create courses should be allowed to create new content
libraries.
This commit introduces the new Forum V2 application, allowing users to choose between the legacy Forum V1 and the new Forum V2 at the course level.

Key Changes:
- Added waffle flag `discussions.enable_forum_v2` to enable Forum V2 for selected courses, allowing coexistence with Forum V1.
- Default data storage for Forum V2 is set to MongoDB, with an option to switch to MySQL using the waffle flag `forum_v2.enable_mysql_backend`.
- Introduced management command `forum_migrate_course_from_mongodb_to_mysql` for per-course data migration from MongoDB to MySQL.

Note: This PR does not include all unit tests for the Forum V2 native API due to ongoing migration efforts. Further updates will follow to ensure full test coverage before final release.

Co-authored-by: [Muhammad Faraz Maqsood] <[email protected]>
Co-authored-by: [Ali Salman] <[email protected]>
To reproduce the error:
- switch to mongodb from mysql for a specific course.
- create a thread and report the thread. It'll throw an error due to wrong positioning of the arguments.

So, this commit
- uses keyword arguments in flag APIs
- adds mock tests for code coverage
Backported because this fixes an issue where large instances couldn't use this command/feature at all.
This change addresses an issue reported while testing Sumac, where the API V2 is on by default in the authoring MFE: openedx/wg-build-test-release#428. It fails when retrieving an empty list of courses with the queryparams api/contentstore/v2/home/courses?page=1&order=display_name. When this was implemented, the course authoring MFE rendered the empty lists only with page=1 query param (didn't do any filtering/ordering by default), which was later changed to page=1&order=display_name which now ordered by default.

This issue occurs because all the filtering and ordering are done under the assumption that course_overviews is always a query set. However, that's only true when there are courses available and CourseOverview.get_all_courses is used. When not, an empty list is returned instead, raising a 500 error in Studio.
The previous pattern for matching was too broad and would break
the rendering of assets that were prefixed with "xblock".
We're still running with 3.11 in sumac so we should be building the docs
with python 3.11
@feanil feanil requested a review from a team as a code owner December 10, 2024 16:16
@feanil feanil closed this Dec 10, 2024
@feanil feanil deleted the feanil/fix_docs_build branch December 10, 2024 16:17
@feanil feanil restored the feanil/fix_docs_build branch December 10, 2024 16:18
@feanil feanil deleted the feanil/fix_docs_build branch December 10, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.