Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sumac] fix: Show published count component in library content picker (#1481) #1521

Conversation

ChrisChV
Copy link
Contributor

When using the library component picker, show the correct number on component count (published components) in collection cards.

(cherry picked from commit 624f5ad)

Backport of #1481

…x#1481)

When using the library component picker, show the correct number on component count (published components) in collection cards.
@ChrisChV ChrisChV requested a review from a team as a code owner November 19, 2024 21:32
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV
Copy link
Contributor Author

CC @farhaanbukhsh

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/sumac.master@e6d9f3a). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/sumac.master    #1521   +/-   ##
============================================================
  Coverage                             ?   93.17%           
============================================================
  Files                                ?     1050           
  Lines                                ?    20418           
  Branches                             ?     4289           
============================================================
  Hits                                 ?    19025           
  Misses                               ?     1333           
  Partials                             ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but we'll have to resolve some issues with openedx/edx-platform#35886 before we can merge this.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Nov 21, 2024
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this: on a Sumac tutor devstack, following the instructions from openedx/edx-platform#35734

@bradenmacdonald
Copy link
Contributor

FYI on this backport, @farhaanbukhsh

@bradenmacdonald bradenmacdonald merged commit 13bce7e into openedx:open-release/sumac.master Nov 21, 2024
8 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/sumac/FAL-3921-collection-count-published branch November 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants