Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing definition of archived #951

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Feb 13, 2024

Changing the definition of an archived course to also include courses where their only course run statuses are archived or archived and unpublished.

@kiram15 kiram15 requested a review from katrinan029 February 13, 2024 05:16
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 100 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (84ae26a) 83.16%.
Report is 153 commits behind head on master.

Files Patch % Lines
src/components/academies/AcademyContentCard.jsx 60.67% 34 Missing and 1 partial ⚠️
src/components/app/App.jsx 0.00% 8 Missing ⚠️
src/components/app/EnterpriseAppPageRoutes.jsx 0.00% 6 Missing ⚠️
src/components/course/data/utils.jsx 96.00% 6 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/academies/data/hooks.js 86.20% 4 Missing ⚠️
src/components/course/data/hooks.jsx 94.02% 4 Missing ⚠️
...ourse-header/data/hooks/useCourseRunCardAction.jsx 50.00% 3 Missing ⚠️
...oard/main-content/course-enrollments/data/hooks.js 95.58% 3 Missing ⚠️
...onents/enterprise-user-subsidy/data/hooks/hooks.js 90.32% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
- Coverage   84.87%   83.16%   -1.71%     
==========================================
  Files         320      344      +24     
  Lines        6399     7426    +1027     
  Branches     1552     1818     +266     
==========================================
+ Hits         5431     6176     +745     
- Misses        941     1212     +271     
- Partials       27       38      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant