-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEL-3420: Added check for rich text paragraph title. #320
base: 1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a few lines in the paragraphs test to assert the absense of the wrapper and presence when needed.
{% include '@oe-bcl/bcl-heading/heading.html.twig' with { | ||
title: content.field_oe_title, | ||
} only %} | ||
{% if content.field_oe_title is not empty %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the |field_value filter to avoid render meta giving false negatives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -46,6 +46,7 @@ abstract class ParagraphsTestBase extends AbstractKernelTestBase { | |||
'paragraphs', | |||
'text', | |||
'typed_link', | |||
'twig_field_value', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@@ -108,7 +108,7 @@ public function testRendering(): void { | |||
'second option', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
/**
* {@inheritdoc}
*/
protected static $modules = [
'twig_field_value',
];
the reason is that only this one needs it, lets start to be more efficient, the tests are slow enough
No description provided.