OPENEUROPA-371: Task Runner: allow bin directory to be derived by composer.json "bin-dir" property

[claudiu-cristea]

In my projects, I like to use ./bin as binary directory. This is easy to config in composer.json:

    "config": {
        "bin-dir": "bin/"
    },

But the task runner uses its own bin dir, independent from composer.

Proposal: Default to Composer's bin dir but still allow to override this behaviour in ./runner.yml.dist or ./runner.yml.

[drupol]

Hi Claudiu,

Very nice contribution :)

I've got a small question, what about using the Symfony Dotenv component for environment variables?

[claudiu-cristea]

@drupol, As I see Dotenv's purpose is to read files with ENV vars that are storing sensitive data. For example you don't store passwords in the VCS but you can make them available via ENV vars. Then, in the CI, you set a file from where the vars are read. But we don't set any ENV vars in our code, we're only reading a potential var called COMPOSER_BIN_DIR using the native PHP's getenv() function. There is an exception in tests, where we set the variable for test purposes but that it's just using the PHP's native putenv() function. I really don't see a real use case for symfony/dotenv here.

[drupol]

Ok fair enough !

Thanks for the explanation :-)

[ademarco]

@claudiu-cristea we have opened an issue about this on our board.