Move from Travis CI to Github Actions #103
Conversation
Signed-off-by: Akos Veres <[email protected]>
Signed-off-by: Akos Veres <[email protected]>
Signed-off-by: Akos Veres <[email protected]>
Signed-off-by: Akos Veres <[email protected]>
Signed-off-by: Akos Veres <[email protected]>
.github/workflows/build.yaml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] |
There was a problem hiding this comment.
Why is this limited to master?
.github/workflows/build.yaml
Outdated
| build: | ||
| strategy: | ||
| matrix: | ||
| go-version: [1.11.x] |
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Akos Veres <[email protected]>
.github/workflows/publish.yaml
Outdated
| publish: | ||
| strategy: | ||
| matrix: | ||
| go-version: [1.11.x] |
There was a problem hiding this comment.
This should probably match the other workflows with 1.13
|
Have you tested a release build on your own account? Most that I merged yesterday failed leaving broken tags |
Signed-off-by: Akos Veres <[email protected]>
I have as much as I could, in this repository we only take the git tag, not the sha and that looks correct. |
| push: | ||
| branches: "*" | ||
| pull_request: | ||
| branches: [ master ] |
There was a problem hiding this comment.
This should be "*" based on the discussions Slack
|
@akosveres do you have a moment to revisit the comments today? |
| build: | ||
| strategy: | ||
| matrix: | ||
| go-version: [1.13.x] |
|
This PR is required to complete our migration, so I'm closing due to inactivity. @utsavanand2 please can you take over in a new PR and make this work like the faas-netes or faas build please? Pay attention to how we set the version and commit information in the image and the GitHub Action. |
Description
The pull request has the following changes:
Motivation and Context
Fixes issue GitHub Actions Migration - tracking issue faas#1585
How Has This Been Tested?
I've done tests on my fork:
Successful build workflow https://github.com/akosveres/nats-queue-worker/runs/1365348972?check_suite_focus=true
Succesful publish workflow https://github.com/akosveres/nats-queue-worker/runs/1365361432?check_suite_focus=true
Types of changes
Checklist:
git commit -s