-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that topology charges are ignored #1064
Conversation
I read the updated doc strings, and I'm not sure the changes make the implications sufficiently clear for a use case like Irfan's. Should it explicitly say somewhere that in no case can isomorphic molecules end up with different charge sets? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattwthompson this seems to address #1059 but not #1058 is this intended? (the fixes says 1058, the linked issue is 1059..)
Whoops, yes, this is meant to address #1059! |
Separate issue (due to my mistake) but in #1070 I'm adding an error when |
Description
Resolves #1059
Checklist
from_smirnoff
_without_charge_from_molecules
silently assigns all isormophic molecules the same partial charges #1059