Skip to content

Commit

Permalink
Fix issue 223 and add test (#294)
Browse files Browse the repository at this point in the history
* fix issue 223 and add test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* actually commit test molecules

* update releasehistory

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
j-wags and pre-commit-ci[bot] authored Aug 13, 2024
1 parent bc0c4c3 commit 90b3252
Show file tree
Hide file tree
Showing 4 changed files with 643 additions and 2 deletions.
9 changes: 8 additions & 1 deletion docs/releasehistory.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@ Releases follow the ``major.minor.micro`` scheme recommended by
Releases are given with dates in DD-MM-YYYY format.

<!--## Version / Date DD-MM-YYYY -->
## Current development

## 0.53.0 / 12-8-2024

### Bugfixes
* [PR #294:]: Fixes [a bug](https://github.com/openforcefield/openff-qcsubmit/issues/223) in ConformerRMSDFilter where automorphs are sometimes incorrectly handled, leading to incorrect atom mappings used in RMSD calculations.


## 0.52.0 / 22-07-2024

### API breaking changes
* [PR #288:]: Adds a new named argument, `properties=False` to `QCSpec.qc_keywords`, changing it from a property to a method.
Expand Down
13 changes: 13 additions & 0 deletions openff/qcsubmit/_tests/results/test_filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
SMILESFilter,
UnperceivableStereoFilter,
)
from openff.qcsubmit.utils import get_data

from . import RecordStatusEnum, SinglepointRecord

Expand Down Expand Up @@ -397,6 +398,18 @@ def test_rmsd_conformer_filter_canonical_order(monkeypatch):
assert filtered_collection.n_results == 1


def test_issue_223(monkeypatch):
mols = Molecule.from_file(get_data("issue_223_confs.sdf"))
result_collection = mock_optimization_result_collection(
{"http://localhost:442": mols}, monkeypatch
)

filtered_collection = result_collection.filter(ConformerRMSDFilter())

assert filtered_collection.n_molecules == 1
assert filtered_collection.n_results == 1


@pytest.mark.parametrize(
"rmsd_function_name",
[
Expand Down
Loading

0 comments on commit 90b3252

Please sign in to comment.