clarify fractional bondorder method support #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I'm in favor of this change as it makes it clear what is and is not supported.
I don't think the scope is large enough to necessitate an EP review, but I do think the change is not strictly negligible and I'm not going to approve + merge it alone. I'd like input from @j-wags (or possibly @lilyminium) if implementing this would impact any fitting efforts. It's possible I'm unaware of experiments using other methods - since, well, I'm not one of the people doing them. The current implementation defines a default but does not seem to forbid other values from being passed through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41 (comment) for some details.