β¨(react) make optional DataGrid row selection #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π¦ Changeset detectedLatest commit: 60d17e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NathanVss
force-pushed
the
feat/datagrid-hide-select-checkboxes
branch
from
e2adb7d
to
486f028
Compare
When using the selection feature on another project we realized that we needed to make some row non selectable at all by hiding the checkbox completely.
NathanVss
force-pushed
the
feat/datagrid-hide-select-checkboxes
branch
from
486f028
to
60d17e3
Compare
jbpenrath
reviewed
Aug 21, 2024
| return ( | ||
| <Checkbox | ||
| checked={row.getIsSelected()} | ||
| disabled={!row.getCanSelect} |
There was a problem hiding this comment.
Your change highlights this logic is wrong
Suggested change
| disabled={!row.getCanSelect} | |
| disabled={!row.getCanSelect()} |
There was a problem hiding this comment.
You are right on this, but we need a way to hide checkboxes, not just grey them out. WDYT about adding a props on DataGrid named hideSelectCellWhenDisabled ?
There was a problem hiding this comment.
Woops! I did not our reply ...
Ok let's do that
| @@ -70,6 +70,10 @@ below the table. | |||
|
|
|||
| <Canvas sourceState="shown" of={Stories.ClientSideWithPagination}/> | |||
|
|
|||
| You can also make a row non selectable by setting using `enableRowSelection` as a callback function that returns a boolean based on a condition. | |||
There was a problem hiding this comment.
Suggested change
| You can also make a row non selectable by setting using `enableRowSelection` as a callback function that returns a boolean based on a condition. | |
| You can also make a row non selectable by setting `enableRowSelection` prop with a callback function that returns a boolean based on a condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there π
When using the selection feature on another project we realized that we needed to make some row non selectable at all by hiding the checkbox completely.
Result
Use case
We are building a file explorer in which we want to allow users to select files but not the folders, see:
