-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(project) add eucalyptus/3/wb release #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
force-pushed
the
add-eucalyptus.3-wb
branch
from
November 14, 2019 08:55
082ec17
to
fb9756d
Compare
jmaupetit
changed the title
🚚(project) add eucalyptus/3/wb release
✨(project) add eucalyptus/3/wb release
Nov 14, 2019
rmoch
reviewed
Nov 14, 2019
This comment has been minimized.
This comment has been minimized.
jmaupetit
force-pushed
the
add-eucalyptus.3-wb
branch
from
November 25, 2019 08:40
a1a2201
to
81a0e3c
Compare
@rmoch ready for a new review 🙏 |
sampaccoud
reviewed
Nov 25, 2019
jmaupetit
force-pushed
the
add-eucalyptus.3-wb
branch
3 times, most recently
from
December 1, 2019 18:33
2ce3a89
to
19f48b9
Compare
I think we are ready to merge this @sampaccoud & @rmoch Just need your approval on it 🙏 |
sampaccoud
reviewed
Dec 1, 2019
rmoch
reviewed
Dec 2, 2019
rmoch
reviewed
Dec 2, 2019
jmaupetit
commented
Dec 3, 2019
lunika
force-pushed
the
add-eucalyptus.3-wb
branch
2 times, most recently
from
December 3, 2019 11:33
b98ae3a
to
969f67f
Compare
Install and configure fun-apps in the edx-platform eucalyptus.3 release.
To connect celery to redis-sentinel we use the plugin celery-redis-sentinel. Also to use session in redis, the setting allowing to change the backend to use was missing and setting to configure redis were also missing. We added them, it is now possible to use redis to store sessions.
jmaupetit
force-pushed
the
add-eucalyptus.3-wb
branch
from
December 3, 2019 13:30
969f67f
to
bc598f8
Compare
lunika
reviewed
Dec 3, 2019
rmoch
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
lunika
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are running white brands using our OpenEdx's eucalyptus fork with a custom flavor of fun-apps. While migrating all our infrastructure to openshift, we need to build those base images.
Proposal
Install and configure fun-apps in openfun edx-platform's eucalyptus fork.