🎨(api) convert camelCase variables to snake_case #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
changed the title
lebaudantoine
commented
Sep 14, 2023
lebaudantoine
force-pushed
the
fix/camelcase-naming
branch
2 times, most recently
from
df40712 to
533e362
Compare
|
@lebaudantoine some camelCase remain in Pydantic models in models. To align with this PR, we could standardise all our Pydantic models, but that could be done in another PR |
|
Issue opened @quitterie-lcs #439 |
lebaudantoine
force-pushed
the
fix/camelcase-naming
branch
from
b7ceabe to
8c94cb1
Compare
Implemented camelCase aliases on API routes' params. Ensures PEP8 compliance without disabling PyLint.
Implemented camelCase aliases on attributes of LRSStatementQuery. Ensures PEP8 compliance without disabling PyLint.
lebaudantoine
force-pushed
the
fix/camelcase-naming
branch
from
8c94cb1 to
c2dfbaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ensures PEP8 compliance without disabling PyLint.
Proposal
Implemented
camelCasealiases on attributes or routes' parameters.Let me know if I am being too pedantic, and this breaking change is not worth it.