Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update unittest and improvement typehinting #829

Merged
merged 2 commits into from
Jul 15, 2024
Merged

chore: update unittest and improvement typehinting #829

merged 2 commits into from
Jul 15, 2024

Conversation

slowy07
Copy link
Member

@slowy07 slowy07 commented Jul 15, 2024

improvement typehinting by on colormaps.py and adding unitesting on test_colormaps by:

  • test invalid colormaps
  • test colormap with n class
  • adding pallete with commented for future dev or test

@slowy07
Copy link
Member Author

slowy07 commented Jul 15, 2024

sir @giswqs , should us_states.kml deleted ?

@giswqs
Copy link
Member

giswqs commented Jul 15, 2024

Yes, the kml file should be deleted.

@slowy07
Copy link
Member Author

slowy07 commented Jul 15, 2024

already removed sir @giswqs

@giswqs giswqs merged commit 9f27657 into opengeos:master Jul 15, 2024
14 checks passed
@slowy07 slowy07 deleted the improve-colormaps branch July 15, 2024 22:06
kuzja111 pushed a commit to kuzja111/leafmap that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants